READING / concepts/code-review-contract.md

A published OKF snapshot. Follow the map, then read at your pace.

Knowledge mapSee how this bundle connects3 concepts · No internal links yetOpen mapHide map
conventionunverifiedstable

Code review contract

Authors prepare

Reviewers check in order

  1. Correctness of the core logic.
  2. Security: input handling, auth boundaries, secrets.
  3. Tests that would fail if the feature broke.
  4. Readability and consistency with neighboring code.

Comments state the problem and the reason; suggested fixes are welcome but the author applies them. Approval means "I would defend this in production".

Agent-generated code

Review it exactly like human code, plus one rule: demand provenance for any non-obvious claim. If the agent says "this matches our convention", the cited convention document should actually say that. Uncited convention claims are treated as unverified and checked manually.

FOCUS READER

Speed read

Paused

Ready

300 wpm

Space play/pause · arrows step or change rate · Escape closes